-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sum/Avg aggregation queries #715
Merged
Merged
Changes from 35 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
608464a
Feat: Sum/Avg Feature
Mariatta 7e4d335
Merge branch 'main' into feat-sum-avg-pr
daniel-sanche f1322b5
fixed proto sum attribute name
daniel-sanche ed247b9
added query tests with alias unset
daniel-sanche b3d1d7a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] eaac103
added async tests
daniel-sanche 19c2c4b
added missing decorators
daniel-sanche 20ad46e
fixed wrong expected values in tests
daniel-sanche c2a804d
fixed empty avg aggregations
daniel-sanche 59a02c2
ran blacken
daniel-sanche 91dbc48
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 3901dd7
Merge branch 'feat-sum-avg-pr' of https://github.com/googleapis/pytho…
gcf-owl-bot[bot] dff8459
aggregation test should cover all aggregations
daniel-sanche 3e66842
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] ed06271
fixed async test
daniel-sanche 47d45da
improved transaction tests
daniel-sanche 90b006c
cleaned up new tests
daniel-sanche 5f00661
removed test logic that belongs in unit tests
daniel-sanche 2340fea
ran blacken
daniel-sanche 63f252a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 109e8b8
Merge branch 'feat-sum-avg-pr' of https://github.com/googleapis/pytho…
gcf-owl-bot[bot] 85c8dbd
reverted removed line
daniel-sanche 93ff4bb
Merge branch 'main' into feat-sum-avg-pr
kolea2 e60aa75
fix docstrings
daniel-sanche 6a0950a
accept FieldPath for aggregations
daniel-sanche e03871e
fixed docstrings
daniel-sanche bb9e8bb
made test changes to avoid index requirements
daniel-sanche a488a6d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] b258fde
fixed lint issues
daniel-sanche 6d3b154
added field path to collections
daniel-sanche 4b6de1a
Merge branch 'main' into feat-sum-avg-pr
daniel-sanche 7b40aa7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] c06aa19
fixed docs issue
daniel-sanche 176ce2d
added tests with start_at
daniel-sanche 1b16357
add no cover marks to TYPE_CHECKING
daniel-sanche d42bf07
Merge branch 'main' into feat-sum-avg-pr
daniel-sanche 0e969a6
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 82bde42
skip cursor aggregations
daniel-sanche 9a10dc2
import query type
daniel-sanche 3bb4bf5
fixed no cover comments
daniel-sanche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to https://github.com/googleapis/java-firestore/pull/1387/files#diff-fdd9700384056ce568a3fd41266eb1dfc5487c620bade78cde24dd677d7016b5R83, should we also have a constructor that accepts a
FieldPath
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Although I used the same constructor with an additional accepted type, which is how Python handles this kind of thing