Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the hand-written _commit_with_retry logic, in favor of built-in gapic retry implementation
According to the docstrings, this custom retry logic was put in place because the gapic layer originally didn't retry ServiceUnavalable errors by default, but that has changed over time.
Now this retry logic is just stacking an extra retry loop on top of the built-in one. Additionally, the custom retry loop doesn't have an exit condition, making it susceptible to infinite loops
At this point, it is safer to remove this custom logic, and rely on only the built-in gapic retry behavior
More detailed refactors of retries coming later, but this is a step in that direction
Fixes #850