Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with the JSON Schema #2456

Open
gk-drw opened this issue Dec 18, 2024 · 1 comment
Open

Potential issue with the JSON Schema #2456

gk-drw opened this issue Dec 18, 2024 · 1 comment
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@gk-drw
Copy link

gk-drw commented Dec 18, 2024

Environment details

  • OS: any (MacOS / Linux)
  • Node.js version: any (v20)
  • npm version: any
  • release-please version: latest

Steps to reproduce

A schema that contains incorrect properties isn't reported, e.g.

{
  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/refs/heads/main/schemas/config.json",
  "packages": {
    ".": {
      "application-type": "simple",
      "extra-files": ["README.md"],
      "other-non-existent-property": "no-errors"
    }
  }
}

doesn't report issues.

This is because ReleaserConfigOptions doesn't have "additionalProperties": false in its specs.

Adding this field would cause conflicts with allOf, so that needs to be changed to anyOf as well to allow for both single-package configs and multi-package configs

@gk-drw gk-drw added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 18, 2024
@gk-drw
Copy link
Author

gk-drw commented Dec 18, 2024

tagging @isaacsanders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants