Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Owlbot (owlbot copy-code) in hermetic build #3359

Open
JoeWang1127 opened this issue Nov 11, 2024 · 0 comments
Open

Replace Owlbot (owlbot copy-code) in hermetic build #3359

JoeWang1127 opened this issue Nov 11, 2024 · 0 comments
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

In hermetic build, Owlbot is used to copy pre-processed library to its final destination for post-processing. It needs a configuration file, .OwlBot-hermetic.yaml to specify how to copy generated files to the destination.

The configuration cause some confusion, e.g., after adding a module in a library, we also need to modify the configuration so that Owlbot can copy the newly generated module to its destination (commit).

In addition, we need to install npm, nodejs and git in the docker image to support Owlbot, which may introduce security vulnerabilities.

We should replace Owlbot copy-code function with our own implementation and remove the configuration file.

Note that Owlbot has more functions and handwritten libraries may contain customizations, we need to support them as well.

@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. hermetic-build labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant