Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse the release note from a BUILD-only commit in googleapis #3368

Open
JoeWang1127 opened this issue Nov 13, 2024 · 0 comments
Open

Parse the release note from a BUILD-only commit in googleapis #3368

JoeWang1127 opened this issue Nov 13, 2024 · 0 comments
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

Parse the release note from a BUILD-only commit in googleapis, e.g., googleapis/googleapis@de97a5f.

Modify

sdk-platform-java/hermetic_build/release_note_generation/generate_pr_description.py

Line 154 in 4d4c798

if versioned_proto_path in paths and (not file.endswith("BUILD.bazel")):

@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. hermetic-build labels Nov 13, 2024
@JoeWang1127 JoeWang1127 mentioned this issue Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoeWang1127