Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/do not generate pom.xml if no source code exists in the module #3392

Open
JoeWang1127 opened this issue Nov 21, 2024 · 0 comments
Open
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

JoeWang1127 commented Nov 21, 2024

We need to remove empty modules (except for pom.xml) when transport changes.

For example, in googleapis/googleapis@de97a5f, the transport changed from grpc+rest to rest and the source code in the grpc module is removed. However, the pom.xml in the module is not removed and cause test failure in graalvm build:

09:13:06:345 [ERROR] Failed to execute goal org.graalvm.buildtools:native-maven-plugin:0.10.3:test (test-native) on project google-cloud-connectgateway: Missing jar-file for com.google.api.grpc:grpc-google-cloud-connectgateway-v1:jar:0.6.0:test. Ensure that native-maven-plugin runs in package phase. -> [Help 1]

We should either

  1. Remove the pom.xml from a module if there's no source code
  2. Do not generate pom.xml if there's no source code (this is preferable)

part of b/372713264

@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. hermetic-build labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant