chore: update dev guide to get version of gapic-showcase to install. #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lqiu96
reviewed
Feb 8, 2024
| @@ -18,7 +18,7 @@ update to a compatible client version in `./WORKSPACE`. | |||
| ```shell | |||
| # Install the showcase server version defined in gapic-showcase/pom.xml | |||
| cd showcase | |||
| go install github.com/googleapis/gapic-showcase/cmd/gapic-showcase@v"$(cd gapic-showcase;mvn help:evaluate -Dexpression=gapic-showcase.version -q -DforceStdout)" | |||
| go install github.com/googleapis/gapic-showcase/cmd/gapic-showcase@v"$(cd gapic-showcase;mvn help:evaluate -Dexpression=gapic-showcase.version -q -DforceStdout |sed 's/\x1b\[[0-9;]*m//g')" | |||
There was a problem hiding this comment.
Thanks, I just ran command his and ran into the same error. Could you just a comment about the sed command at the end (removing ANSI escape codes)?
Also, I wonder if there is a better way to get the showcase version...
lqiu96
approved these changes
Feb 8, 2024
ddixit14
pushed a commit
that referenced
this pull request
Feb 15, 2024
…2451) This addition removes the trailing ANSI escape sequence (`\x1b[0m`) on the returned version. This regex `\x1b\[[0-9;]*m` matches ANSI escape sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition removes the trailing ANSI escape sequence (
\x1b[0m) on the returned version.This regex
\x1b\[[0-9;]*mmatches ANSI escape sequences.