New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python, samples: add mypy check to samples noxfile #1311

Open

tswast opened this issue Dec 28, 2021 · 1 comment

Labels

samples type: feature request

Contributor

tswast commented Dec 28, 2021

Currently, google-cloud-bigquery runs type checks against samples from the root noxfile. Ideally this would be done in the individual samples noxfiles, so that requirements.txt can be used. https://github.com/googleapis/python-bigquery/blob/08a9bcc16850bbc3cbe0375ef50537edd974f304/noxfile.py#L190-L209

The text was updated successfully, but these errors were encountered:

product-auto-label bot added the samples label

yoshi-automation added the triage me label

busunkim96 added the type: feature request label

Contributor

busunkim96 commented Dec 30, 2021

CC @googleapis/python-samples-owners

yoshi-automation removed the triage me label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment