Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(nodejs): document advanced GAX configuration settings in GAPIC readmes #1410

Closed
bcoe opened this issue Apr 7, 2022 · 1 comment
Closed

docs(nodejs): document advanced GAX configuration settings in GAPIC readmes #1410

bcoe opened this issue Apr 7, 2022 · 1 comment
Assignees
@summer-ji-eng
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bcoe
Copy link
Contributor

bcoe commented Apr 7, 2022

It would be good to document advanced GAX configuration settings for GAPIC libraries in READMES, e.g., retry config.

We reverted #1352 because it was applying templates overly permissively to non GAPIC libraries. What we can do is use .repo-metadata.json to determine if a library is GAPIC (which is one of the documented fields) and then only show this information in the README.
@bcoe bcoe added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 7, 2022
@bcoe
Copy link
Contributor Author

bcoe commented Oct 11, 2023

I think we can close this, but should have this work in mind as we work on doc requirements.

@bcoe bcoe closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@summer-ji-eng summer-ji-eng

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcoe @summer-ji-eng