Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: generated noxfile.py refers to nonexistent noxfile_config.py #1489

Open
hegemonic opened this issue Jul 14, 2022 · 0 comments
Open

python: generated noxfile.py refers to nonexistent noxfile_config.py #1489

hegemonic opened this issue Jul 14, 2022 · 0 comments
Assignees
@parthea
Labels
lang: python Issues specific to Python. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@hegemonic
Copy link

Environment details

n/a

Steps to reproduce

https://github.com/googleapis/synthtool/blob/95d9289a/synthtool/gcp/templates/python_samples/noxfile.py.j2#L35-L40

This template file tells users to copy noxfile_config.py rather than editing noxfile.py. But it appears that the python_samples template doesn't generate a file named noxfile_config.py. For an example, see https://github.com/googleapis/python-iam.

We should clarify these instructions and make sure they're consistent with the generated output.
@hegemonic hegemonic mentioned this issue Jul 14, 2022
Merged
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. lang: python Issues specific to Python. labels Jul 15, 2022
@chingor13 chingor13 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
lang: python Issues specific to Python. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chingor13 @hegemonic @parthea