Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV #1019

Open
waywardmonkeys opened this issue Jul 23, 2024 · 3 comments
Open

MSRV #1019

waywardmonkeys opened this issue Jul 23, 2024 · 3 comments

Comments

@waywardmonkeys
Copy link
Contributor

What is the desired MSRV for this family of crates?

Right now, it is 1.76 to get a build. This is because tests within int-set import std::hash::DefaultHasher which is a new location for it. Prior to 1.76, it was available as std::collections::hash_map::DefaultHasher.

If that's addressed, then the MSRV is 1.75 because code within int-set uses the features described here: rust-lang/rust#91611

@cmyr
Copy link
Member

cmyr commented Jul 23, 2024

I think it's fine to say 1.76 for now, and I would not place much value on trying to maintain a low MSRV for the foreseeable future; that is, if something in a new rust release is useful I'm happy for us to adopt it.

@rsheeter
Copy link
Collaborator

rsheeter commented Jul 23, 2024 via email

@waywardmonkeys
Copy link
Contributor Author

Do you know offhand what that value is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants