Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate aditional steps - const values: Step 3 - Build your own Match Function #293

Open
Kaszanas opened this issue Jun 7, 2023 · 0 comments

Comments

@Kaszanas
Copy link

Kaszanas commented Jun 7, 2023

Tutorial code contains comments that point towards additional steps. These do not have a full coverage with the documentation. I was debugging matching function build for some time today. In the end it was purely because one const value was commented out and the compiler was not able to find it.

It would be great to have something indicating to the OpenMatch tutorial users have to uncomment something for the build to work

const (
	matchName = "basic-matchfunction"

	// Uncomment if following the tutorial
	// ticketsPerPoolPerMatch = 4
)

Or the tutorial code could have this value integrated into the makeMatches() function.

func makeMatches(p *pb.MatchProfile, poolTickets map[string][]*pb.Ticket) ([]*pb.Match, error) {
	var matches []*pb.Match
	count := 0
	ticketsPerPoolPerMatch := 4
	...
}
Kaszanas added a commit to Kaszanas/open-match-docs that referenced this issue Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant