Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleteScript should be private #208

Open
jpoehnelt opened this issue Mar 16, 2021 · 3 comments
Open

deleteScript should be private #208

jpoehnelt opened this issue Mar 16, 2021 · 3 comments

Comments

@jpoehnelt
Copy link
Contributor

I am not aware of a valid use for deleteScript. It should be removed from the public class interface.

@jpoehnelt jpoehnelt added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Mar 16, 2021
@martijnmelchers
Copy link

I disagree, we use it to unload the script on language change and load it back in with a new language.

@chrisjshull
Copy link
Contributor

I disagree, we use it to unload the script on language change and load it back in with a new language.

FWIW, the API does not officially support doing that.

@usefulthink
Copy link
Contributor

Once the maps API is starting to use WebComponents (currently in beta), it will no longer be possible to reload the Maps JavaScript API. See also my comment here: #100 (comment). Hence, there will no longer be support for this in the next major-release of the api-loader.

@usefulthink usefulthink removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants