Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Error promise rejection after map fails to load #350

Closed
ledleds opened this issue Aug 16, 2021 · 2 comments · Fixed by #351
Closed

Non-Error promise rejection after map fails to load #350

ledleds opened this issue Aug 16, 2021 · 2 comments · Fixed by #351
Labels

Comments

@ledleds
Copy link

ledleds commented Aug 16, 2021

Hello!

We are currently using google-map-react in production which has this project as a dependency.

We've recently been seeing lots of errors in Sentry:

Event: Non-Error promise rejection captured with keys: currentTarget, isTrusted, target, type

With the object:

currentTarget: [object Null], 
isTrusted: [object Event], 
target: head > script#__googleMapsScriptId[type="text/javascript"], 
type: error

I saw that others had mentioned this library as a possible reason for this in this issue in Sentry: getsentry/sentry-javascript#2546

We see this error after 3 retries, after the third Failed to load Google Maps script, retrying in 24 ms. we see this error.

I've had to make a lot of assumptions so sorry if I'm wrong about this, I'm piecing what I can together from logs as I haven't been able to reproduce this myself. But I'm wondering if the error has to be handled differently in the loadErrorCallback function.

@jpoehnelt
Copy link
Contributor

Thanks for reporting. Fix incoming!

@github-actions
Copy link

🎉 This issue has been resolved in version 1.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jpoehnelt jpoehnelt removed their assignment Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants