You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This repository is set up to "Squash Merge" and has a "Conventional Commit" presubmit check to enforce a style of commit message.
But "Squash Merge" obliterates the commit messages that "Conventional Commit" tries to enforce. Instead the Pull Request content is used - so people submitting pull requests are forced to do throw-away work.
This repository needs to be on a "Rebase" workflow for the "Conventional Commit" presubmit check to provide any added value. Or we should disable the conventional commits presubmit because it's not actually enforcing anything.
The text was updated successfully, but these errors were encountered:
bshi
added
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
triage me
I really want to be triaged.
labels
Sep 10, 2024
This repository is set up to "Squash Merge" and has a "Conventional Commit" presubmit check to enforce a style of commit message.
But "Squash Merge" obliterates the commit messages that "Conventional Commit" tries to enforce. Instead the Pull Request content is used - so people submitting pull requests are forced to do throw-away work.
https://lore.kernel.org/lkml/CAHk-=wjbtip559HcMG9VQLGPmkurh5Kc50y5BceL8Q8=aL0H3Q@mail.gmail.com/
This repository needs to be on a "Rebase" workflow for the "Conventional Commit" presubmit check to provide any added value. Or we should disable the conventional commits presubmit because it's not actually enforcing anything.
The text was updated successfully, but these errors were encountered: