Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled node type ConditionalExpression #410

Closed
nth10sd opened this issue Jan 15, 2024 · 3 comments
Closed

Unhandled node type ConditionalExpression #410

nth10sd opened this issue Jan 15, 2024 · 3 comments

Comments

@nth10sd
Copy link

nth10sd commented Jan 15, 2024

node parser.js ../../Protobuf/ast.proto code.js output.ast.proto

code.js:

1 ? 0 : 0;

Are ternary operators on latest rev d386a83 supported yet?

<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:556
                throw "Unhandled node type " + node.type;
                ^
Unhandled node type ConditionalExpression
Thrown at:
    at visitExpression (<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:556:17)
    at visitStatement (<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:119:28)
    at visitProgram (<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:51:37)
    at parse (<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:561:12)
    at <repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:570:15
    at finish (<repo>/Sources/Fuzzilli/Compiler/Parser/node_modules/protobufjs/src/root.js:105:9)
    at process (<repo>/Sources/Fuzzilli/Compiler/Parser/node_modules/protobufjs/src/root.js:143:13)
    at <repo>/Sources/Fuzzilli/Compiler/Parser/node_modules/protobufjs/src/root.js:195:17
    at fetchReadFileCallback (<repo>/Sources/Fuzzilli/Compiler/Parser/node_modules/@protobufjs/fetch/index.js:51:19)
    at readFileAfterClose (node:internal/fs/read/context:68:3)
@saelo
Copy link
Collaborator

saelo commented Jan 18, 2024

Hi! The parser/compiler isn't feature complete, but we're happy to take pull requests! This is probably relatively easy to implement since we do support ternary operators in the IL.

@nth10sd
Copy link
Author

nth10sd commented Jul 27, 2024

@TobiasWienand @saelo Perhaps this is fixed by #438?

@saelo
Copy link
Collaborator

saelo commented Jul 30, 2024

Right, this should indeed be fixed now!

@saelo saelo closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants