Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed: Expected variable declaration as init part of a for-in loop, found Identifier #412

Open
nth10sd opened this issue Jan 17, 2024 · 1 comment

Comments

@nth10sd
Copy link

nth10sd commented Jan 17, 2024

node parser.js ../../Protobuf/ast.proto code.js output.ast.proto

code.js:

for (x in y) {}

Tested on rev d386a83.

<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:17
            throw "Assertion failed: " + msg;
            ^
Assertion failed: Expected variable declaration as init part of a for-in loop, found Identifier
Thrown at:
    at assert (<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:17:13)
    at visitStatement (<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:268:17)
    at visitProgram (<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:51:37)
    at parse (<repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:561:12)
    at <repo>/Sources/Fuzzilli/Compiler/Parser/parser.js:570:15
    at finish (<repo>/Sources/Fuzzilli/Compiler/Parser/node_modules/protobufjs/src/root.js:105:9)
    at process (<repo>/Sources/Fuzzilli/Compiler/Parser/node_modules/protobufjs/src/root.js:143:13)
    at <repo>/Sources/Fuzzilli/Compiler/Parser/node_modules/protobufjs/src/root.js:195:17
    at fetchReadFileCallback (<repo>/Sources/Fuzzilli/Compiler/Parser/node_modules/@protobufjs/fetch/index.js:51:19)
    at readFileAfterClose (node:internal/fs/read/context:68:3)
@saelo
Copy link
Collaborator

saelo commented Jan 18, 2024

Ah good catch, I think this is actually a problem with the IL rather than the compiler/parser as we currently expect ForIn loops to define a new variable (they must have one inner output), while in this case we'd either reuse an existing variable or create a global one. So I think fixing this properly might require introducing a new IL operation like ForInWithReassign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants