Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different lighting in left, right view #412

Open
Mandelbrow opened this issue May 29, 2023 · 6 comments
Open

Different lighting in left, right view #412

Mandelbrow opened this issue May 29, 2023 · 6 comments

Comments

@Mandelbrow
Copy link

Mandelbrow commented May 29, 2023

Screenshot_20230529-173519

It looked fine the first minute, or so. Then the right eye view started to become lighter, and the left eye view apperes to be darker. Also noted a decrese in performance, and the Recenter method from code is terrible.

This project is running Unity 2020.3.48, Color Space Gamma, and OpenGLES3 on Android 11, and the only difference was update of the Cardboard SDK to 1.21.0.

Whats going on...?

Edit: Think this is a part of what's missing, at least for the Recenter to work as expected in 1.21.0. When did it go away?

void HeadTracker::SetRecenterRotationFromViewportOrientation(
    CardboardViewportOrientation viewport_orientation) {
  const double yaw_angle =
      GetRotation(viewport_orientation, 0 /* now */).GetYawAngle();
  recenter_rotations_[viewport_orientation] *=
      Rotation::FromYawPitchRoll(-yaw_angle, 0., 0.);
}
@arilow
Copy link

arilow commented Jun 2, 2023

Thanks @Mandelbrow for reporting this. Unfortunately we couldn’t reproduce it locally. In order to allow us to reproduce this issue, could you please check the following items?

  • Which Cardboard SDK version were you using where this issue does not appear? Is it v1.20?
  • Were you able to reproduce it with the cardboard sample?
  • If yes would you please share the required steps to expose the issue?
  • If not, we would need you to share with a simple repro project where this issue is depicted.

About the recentering issue please create a new ticket. FYI SetRecenterRotationFromViewportOrientation() was replaced in v1.9.0.

Thanks!

@Mandelbrow
Copy link
Author

Mandelbrow commented Jun 5, 2023

The Recentering was working as expected in v1.8.0. Now it fails when leaning the head #415

Regarding the burned out light in the right eye view. It appears to happens with some of the textures on the Terrain. The other details looks fine. Not really sure if there are any differences at all between the broken texture, and the others. They all looked fine when they were rendered in SDK 1.8.0, Unity was also by the way updated from 20.3.45, to 20.3.48. Perhaps that's the problem?

@arilow
Copy link

arilow commented Jun 16, 2023

Thanks @Mandelbrow for creating another ticker for the recentering issue and for the provided information.

In order to continue debugging this issue, we will need the required steps on how to reproduce the issue on the Hellocardboard scene or a simple repro project where this issue can be depicted.

Thanks!

@Montie68
Copy link

Hi has anyone figured this out, the different lighting for each eye? We've been having the same problem. Narrowed it down to the terrain as I've tested it with other assets and it doesn't occur with any other type of assets.

using Unity 2022.3.5, cardboard SDK 1.21.0

@Mandelbrow
Copy link
Author

@arilow This bug still exists in Cardboard SDK 1.22.0.

@Mandelbrow
Copy link
Author

Hi, light is still broken on terrains in Unity 2022, and Cardboard SDK 1.25.0.

How to reproduce:
Put more than 4 Textures on the terrain.
Set the Material for the Terrain to use the Built in Shader "Nature/Terrain/Diffuse".
Use OpenGLES3, Built-in Render Pipeline, and build for Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants