Directory / filename collision when deleting

[deeuu]

Summary

Can't delete secret with same name as directory.

Steps To Reproduce

(edited for brevity)

$ gopass list code
├── github
│   └── deeuu
├── gitlab
│   └── deeuu
├── github
└── gitlab

gopass rm code/github                                                                      
Are you sure you would like to delete code/github? [y/N/q]: y
2019/04/24 10:57:53 Cannot remove 'code/github': Is a directory. Use 'gopass rm -r code/github' to delete

Expected behavior

An option (or alternative command) to delete the secret or directory.

Environment

• Ubuntu 18.04.1 LTS
• 4.15.0-47-generic x86_64
• gopass 1.8.3
• apt-get

[ndrewtl]

I've also experienced the same issue using gopass edit--

Error: failed to encrypt secret ./secretname: a folder named ./secretname already exists

Environment

• Arch Linux x86_64, Kernel 5.0.13-arch1-1-ARCH
• gopass 1.8.5 (2019-03-13 17:51:51) go1.12 linux amd64

[martinhoefling]

What would be the expected behavior here? Maybe one also want's prevent the creation of this scenario. What should be deleted first, directory or file?

[deeuu]

What should be deleted first, directory or file?

I'd like to be asked a question along these lines.

Perhaps something like:

'X' is both a secret and a directory; delete secret? [y/N/q]:

Then, if N

Note: use 'gopass rm -r X' to delete the directory.

[espoelstra]

I've hit this when trying to do a gopass mv as well, resulting in fun/weird behaviors. #892 (comment)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[espoelstra]

Did this get fixed?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ndrewtl]

Bumping because this should be fixed-- the behavior I'd like to see if there's ambiguity, is for gopass to prompt which, directory or file, you'd like to move/delete/etc. If you don't like the prompt, perhaps a config option should exist about which should be picked if there is ambitguity.