Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Description #644

Open
ananswam opened this issue Dec 17, 2024 · 0 comments
Open

Bug Description #644

ananswam opened this issue Dec 17, 2024 · 0 comments
Labels
bug Something isn't working triage Needs to be reviewed and assigned

Comments

@ananswam
Copy link

ananswam commented Dec 17, 2024

First ensure you are using a camera that is currently supported by Open GoPro. Any other tickets will be rejected.

Component
What is the bug in?

  • Python SDK

Describe the bug

There is an assert in demos/python/sdk_wireless_camera_control/open_gopro/init.py that specifies Python version < 3.12. However, I found this issue + associated PR merged a few months ago that adds Python 3.12 support, I believe: #588

Does this mean we can open up the assert to go up to 3.12?

I have not done a formal test, but when I just comment out the assert, all the stuff I am doing (mostly camera configuration and webcam capture) works fine on python 3.12.

To Reproduce

Just try to import open_gopro from Python 3.12

Expected behavior

I think the code should just work normally on python 3.12? not sure

Hardware

  • Camera: Hero12 Black
  • From macOS Sequoia or Ubuntu 24.04
@ananswam ananswam added the bug Something isn't working label Dec 17, 2024
@github-actions github-actions bot added the triage Needs to be reviewed and assigned label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Needs to be reviewed and assigned
Projects
None yet
Development

No branches or pull requests

1 participant