Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prisma-client-go support added #384

Closed

Conversation

hosseinmirzapur
Copy link

Closes issue #344

📑 Description

I've added the support for prisma go client to the artisan commands and the list of artisan commands are now updated with prisma commands as I added each command to the database directory service provider and tested each command, so no error happens. This prisma client is not supposed to change the way Goravel handles the DB right now. It's simply a database tool to handle migrations and database schema easier and it's fully compatible with the current built-in ORM tool. I haven't changed the facades.Orm() functionalities, and simply all I did is, added commands for prisma schema. Hope everyone has a better time developing great apps

  • Added prisma commands besides current artisan console commands
  • Prisma Studio command (according to this issue it's in development process)

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required (It doesn't require any changes to the docs, as it has all documentation included here)
  • All the tests have passed

ℹ Additional Information

Dependencies added:

Comparisons between new and old behavior:

  • more artisan commands available, prisma included

@hosseinmirzapur hosseinmirzapur changed the title Feature/prisma-go-client feat: prisma-client-go support added Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (88fc9bc) 69.26% compared to head (c00a57f) 68.67%.
Report is 2 commits behind head on master.

Files Patch % Lines
database/service_provider.go 0.00% 20 Missing ⚠️
database/console/prisma/db_push_command.go 13.33% 13 Missing ⚠️
database/console/prisma/db_exec_command.go 33.33% 10 Missing ⚠️
database/console/prisma/db_pull_command.go 28.57% 10 Missing ⚠️
database/console/prisma/db_seed_command.go 46.66% 8 Missing ⚠️
database/console/prisma/debug_command.go 46.66% 8 Missing ⚠️
database/console/prisma/format_command.go 46.66% 8 Missing ⚠️
database/console/prisma/generate_command.go 46.66% 8 Missing ⚠️
database/console/prisma/init_command.go 52.94% 8 Missing ⚠️
database/console/prisma/migrate_deploy_command.go 52.94% 8 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   69.26%   68.67%   -0.60%     
==========================================
  Files         152      166      +14     
  Lines       10922    11166     +244     
==========================================
+ Hits         7565     7668     +103     
- Misses       2849     2990     +141     
  Partials      508      508              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Support for Go-Prisma-Client
1 participant