Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PZ "Players" command timeout when unsupported characters present #46

Open
SAPHROF opened this issue Feb 27, 2024 · 1 comment
Open

PZ "Players" command timeout when unsupported characters present #46

SAPHROF opened this issue Feb 27, 2024 · 1 comment

Comments

@SAPHROF
Copy link

SAPHROF commented Feb 27, 2024

When player names have invisible characters such as " ‎ ‎", which appears as "-ΓÇÄ ΓÇÄ ΓÇÄ" in the console, RCON will timeout with the following error on the server:

LOG : General , 1709045530266> 97.774.271> RCON: new connection Socket[addr=/127.0.0.1,port=55902,localport=] LOG : General , 1709045530267> 97.774.272> RCON: ID=0 Type=3 Body='' Socket[addr=/127.0.0.1,port=55902,localport=] ERROR: General , 1709045530370> 97.774.374> java.nio.BufferOverflowException ERROR: General , 1709045530370> 97.774.375> at java.base/java.nio.HeapByteBuffer.put(Unknown Source) ERROR: General , 1709045530370> 97.774.375> at java.base/java.nio.ByteBuffer.put(Unknown Source) ERROR: General , 1709045530370> 97.774.375> at zombie.network.RCONServer$ClientThread.handleResponse(RCONServer.java:280) ERROR: General , 1709045530370> 97.774.375> at zombie.network.RCONServer$ClientThread.handlePacket(RCONServer.java:213) ERROR: General , 1709045530370> 97.774.375> at zombie.network.RCONServer$ClientThread.runInner(RCONServer.java:165) ERROR: General , 1709045530370> 97.774.375> at zombie.network.RCONServer$ClientThread.run(RCONServer.java:121)

These player names are visible when running the "players" command directly on the server console itself, but throws this BufferOverflowException when done via RCON.

@PascaleBeier
Copy link

PascaleBeier commented Mar 21, 2024

Noticed the same in palworld for player characters with special characters. I think this might be related.

@outdead would you accept a PR for this? This is something that impacts our metrics endpoints

gorcon/rcon#8 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants