Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] BottomSheetTextInput multine scroll trigger scroll of BottomSheetFlatList Android #1538

Closed
LouisCapelle opened this issue Sep 19, 2023 · 5 comments
Labels
bug Something isn't working no-issue-activity

Comments

@LouisCapelle
Copy link

LouisCapelle commented Sep 19, 2023

Bug

Hello, if my textinput has multine enabled and the user has multiline, the scroll of the bottom sheet textinput trigger the scroll of bottomflatlist and close the keyboard if we reach the top of bottom sheet text input.

Environment info

Library Version
@gorhom/bottom-sheet ^4
react-native 0.70.8
react-native-reanimated ^3.1.0
react-native-gesture-handler ~2.8.0

Steps To Reproduce

  • Create a customFotter with a BottomSheetTextInput inside and enable multiline
Enregistrement.de.l.ecran.2023-09-19.a.16.14.59.mov
Screenrecorder-2023-09-19-16-15-26-439.mp4

Describe what you expected to happen:

  1. It shouldn't close the keyboard when top has been reached and the multine scroll shouldn't trigger the bottomsheetflatlist scroll
@LouisCapelle LouisCapelle added the bug Something isn't working label Sep 19, 2023
@github-actions
Copy link

@LouisCapelle: hello! 👋

This issue is being automatically closed because it does not follow the issue template.

@github-actions github-actions bot reopened this Sep 19, 2023
@LouisCapelle LouisCapelle changed the title [v4] | [v2] BottomSheetTextInput multine scroll trigger scroll of BottomSheetFlatList [v4] BottomSheetTextInput multine scroll trigger scroll of BottomSheetFlatList Sep 19, 2023
@LouisCapelle LouisCapelle changed the title [v4] BottomSheetTextInput multine scroll trigger scroll of BottomSheetFlatList [v4] BottomSheetTextInput multine scroll trigger scroll of BottomSheetFlatList Android Sep 19, 2023
@LouisCapelle
Copy link
Author

LouisCapelle commented Sep 19, 2023

UPDATE : After some investigations on the source code, and afters many tests, it looks like the CustomFooter seems to be the problem. When we start the scroll from the custom footer, the modal start his extension to the second snapPoint...

IMG_4912.1.1.1.mp4

@LouisCapelle
Copy link
Author

UPDATE : Fixed with wrapping the bottom sheet textinput in PanGestureHandler

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

1 participant