[Bug]: Incorrect type for present in Bottom Sheet Modal methods

[dwnste]

Version

v5

Reanimated Version

v3

Gesture Handler Version

v2

Platforms

iOS, Android, Web

What happened?

According to the doc, the type should be any. But in this commit any was changed to never everywhere.

Types were not correctly resolved in the snack.

Reproduction steps

• Pass data of any type to present method

Reproduction sample

https://snack.expo.dev/@dwnste/reproducing-issue

Relevant log output

No response

[omkarmoghe]

Found this issue because I had the same question! I was looking at the map app example code, and was curious how this worked with type never? Also thought it should be any so that you can present the modal with arbitrary data, is there another way to achieve this?

https://github.com/gorhom/react-native-bottom-sheet/blob/master/example/src/screens/integrations/map/MapExample.tsx#L63

[maximpostnikov]

If you don't want to wait for PR #2029, an alternative is to add a custom type to the project and use it as follows:

type BottomSheetModalWithData<T = any> = Omit<BottomSheetModal, 'present'> & { present: (data?: T) => void }

const alertModalPrimaryRef = useRef<BottomSheetModalWithData<AlertModalContentProps>>(null)

const handleUpdatePress = () => {
  alertModalPrimaryRef.current?.present({
      type: 'success',
      test: true,  // Throws error because `test` isn't defined in `AlertModalContentProps`
    })
}

[L-Weisz]

I also have this issue
I had created a discussion here #2005
I just ignored the error for now

[gorhom]

it should be fixed in latest release , thanks to @maximpostnikov PR 🙌