Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated.addWhitelistedUIProps call for decelerationRate in js module of the library causes webview full reload on style change #2076

Closed
zarv1k opened this issue Dec 9, 2024 · 1 comment
Labels
invalid This doesn't seem right

Comments

@zarv1k
Copy link

zarv1k commented Dec 9, 2024

Just import from @gorhom/bottom-sheet causes webview full reload on it's style prop change. That mysterious behaviour happens because of call Animated.addWhitelistedUIProps for decelerationRate prop (decelerationRate already exists in webview library so probably it some how influences on webview and causes full reload)

To be honest it was soo difficult to investigate and localise the issue. I tried to find documentation for reanimated v3 addWhitelistedUIProps function, but with no luck. Is that some deprecated API from reanimated used in fresh version of @gorhom/bottom-sheet?

Just removing the call of addWhitelistedUIProps fixes the issue with webview full reload.

Reproduction steps

I've created test repository for reproducing the issue. Please follow the steps on screen in the example.

https://github.com/zarv1k/WebviewPropsChangeReloadIssue

webview-full-reload-issue

Copy link

github-actions bot commented Dec 9, 2024

Hello @zarv1k 👋, this issue is being automatically closed and locked because it does not follow the issue template.

@github-actions github-actions bot closed this as completed Dec 9, 2024
@github-actions github-actions bot added the invalid This doesn't seem right label Dec 9, 2024
@github-actions github-actions bot locked as spam and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant