-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose error types? #51
Labels
Comments
I think since we have versioning available in Go I'd be more comfortable adding those to the public API. What do you think @elithrar ? |
Agree. This is something I’d like to refactor—and simplify—under my v2
rewrite. Error handling in Go is never straightforward and I don’t think
the current approach in securecookie is ideal.
Moving to a v2 will still be slightly tricky, since there’s the conflict of
“change import path” vs. “break Go users without a version-aware go get” -
that’s something I need to assess in June.
…On Sun, May 27, 2018 at 12:23 AM Kamil Kisiel ***@***.***> wrote:
I think since we have versioning available in Go I'd be more comfortable
adding those to the public API. What do you think @elithrar
<https://github.com/elithrar> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABIcKM-clspvFvH8lUvBEUQ9xfjCxLhks5t2eP_gaJpZM4TVxVw>
.
|
@elithrar any update about this ? |
Any movement here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems like the ideal behavior for a cookie w/ an expired timestamp would be for me to consider it equivalent to http.ErrNoCookie, but right now I can't find a clean way to check for that, since the types of errors are all private.
Am I missing a better workflow or existing clean way to check for this?
The text was updated successfully, but these errors were encountered: