Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with unwrap() #393

Open
jaytaph opened this issue Feb 29, 2024 · 2 comments
Open

Deal with unwrap() #393

jaytaph opened this issue Feb 29, 2024 · 2 comments

Comments

@jaytaph
Copy link
Member

jaytaph commented Feb 29, 2024

There are currently 108 unwrap() calls found in the code. They should be removed and replaced with better checking before using the unwrapped values, as this can go wrong

@Sharktheone
Copy link
Member

This probably shouldn't be only about unwrap(), but also about panic!(). It doesn't need to be completely no_panic as i suggested in #380, since that also restricts the usage of array[index].

@jaytaph
Copy link
Member Author

jaytaph commented Feb 29, 2024

The panic's we can fix in the #380 ticket. It's already in the issue list. This way we keep the PR's a bit smaller. I think most of the issues are either panic and unwrap, but if we find other, we can simply add another ticket.

@Sharktheone Sharktheone moved this to 📝 Todo in Gosub Engine Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📝 Todo
Development

No branches or pull requests

2 participants