Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance lint command for script engine #19

Open
haveiss opened this issue Jul 11, 2023 · 0 comments
Open

enhance lint command for script engine #19

haveiss opened this issue Jul 11, 2023 · 0 comments
Assignees

Comments

@haveiss
Copy link
Collaborator

haveiss commented Jul 11, 2023

Is your feature request related to a problem? Please describe.
Currently, the lint command does not detect any errors in the script for the scripting engine used in the HTTP Extractor and Script Processor.

How to reproduce:

Example recipe:

## invalid-recipe.yaml
version: v1beta1
source:
  scope: gotocompany
  type: http
  config:
    request:
      url: "https://example.com/api/v1/endpoint"
      content_type: application/json
      accept: application/json
    script:
      engine: tengo
      source: |
        asset := new_asset("user" // <-- expected ')'
meteor lint invalid-recipe.yaml

Expected Result:

... recipe error: <show error here>

Some checks were not successful
1 failing, 0 successful, and 1 total

Actual Result:

All checks were successful
0 failing, 1 successful, and 1 total

Describe the solution you'd like
I propose enhancing the lint command to effectively identify and display errors in the script. By implementing this improvement, developers can quickly locate and fix issues, saving time and effort. we can validate recipes more robustly and integrate it into our CI Pipeline to catch any issues before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants