Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

want to add background #29

Closed
SanskritiKhatiyan opened this issue Oct 8, 2021 · 7 comments
Closed

want to add background #29

SanskritiKhatiyan opened this issue Oct 8, 2021 · 7 comments

Comments

@SanskritiKhatiyan
Copy link

SanskritiKhatiyan commented Oct 8, 2021

will add backgound color which is attractive. And i would like to work on this plzz assign this to me.

@gouravkhunger
Copy link
Owner

What kind of background colour? Where would you like it to be?

@SanskritiKhatiyan
Copy link
Author

@gouravkhunger since now the page is white(background) in the 'write the name' page or home page. I can add colour according to your wish it might be a gradient or a normal one

@gouravkhunger
Copy link
Owner

But then the theme selection feature would break, as assigning gradient or bg colour would conflict with other theme colours... I don't think its a good idea for now.

If you really wish to contribute in some way, consider checking out #2

@gouravkhunger
Copy link
Owner

#10 is open for this, check out if you can get some ideas

@SanskritiKhatiyan
Copy link
Author

@gouravkhunger i checked the arrow issue you are mentioning about but i guess its working fine in mobile screen also. Arrow is in the middle.
h1

@SanskritiKhatiyan
Copy link
Author

@gouravkhunger I want to add this kind of light color which infact will not impact any of the color themes and will look better as white is looking so simple. If you find this correct plzz tell me. Also i can browse more colors which are light and will fit with this.
h2

@gouravkhunger
Copy link
Owner

Arrow is in the middle.

But when I tested on real device it wasn't centerd 🤔

And to be honest, white colour feels way better than the one you shared, and I suppose most colours won't be as good as white is right now.

Thanks for the suggestion, I am closing this issue for now, if you have a good idea for the project you are always welcome to open an issue again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants