Skip to content

Conversation

@alan-baker
Copy link
Contributor

CTS for gpuweb/gpuweb#5389

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested review from dneto0 and jrprice October 29, 2025 15:45
Copy link
Contributor

@jrprice jrprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests LGTM but maybe we should also add some coverage via let in an execution test somewhere (like your textureDimensions change)? Otherwise for Tint we won't hit the part of the compiler that actually needs to do something to handle these things.

@alan-baker
Copy link
Contributor Author

These tests LGTM but maybe we should also add some coverage via let in an execution test somewhere (like your textureDimensions change)? Otherwise for Tint we won't hit the part of the compiler that actually needs to do something to handle these things.

I've modified the execution tests for textureDimensions to use a let if supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants