Skip to content

Detect invalid end() in "pass_end_invalid_order" #4501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

Detect invalid end() in "pass_end_invalid_order" #4501

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39cf3f0
Detect invalid end() in "pass_end_invalid_order"
Kangz Nov 12, 2025
a180656
Merge branch 'main' into pass_end_invalid_order
Kangz Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions src/webgpu/api/validation/encoding/encoder_state.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ TODO:
`;

import { makeTestGroup } from '../../../../common/framework/test_group.js';
import { objectEquals } from '../../../../common/util/util.js';
import { AllFeaturesMaxLimitsGPUTest } from '../../../gpu_test.js';

class F extends AllFeaturesMaxLimitsGPUTest {
Expand Down Expand Up @@ -51,9 +50,6 @@ g.test('pass_end_invalid_order')
`
Test that beginning a {compute,render} pass before ending the previous {compute,render} pass
causes an error.

TODO(https://github.com/gpuweb/gpuweb/issues/5207): Resolve whether a validation error
should be raised immediately if '!firstPassEnd && endPasses = [1, 0]'.
`
)
.params(u =>
Expand All @@ -63,8 +59,6 @@ g.test('pass_end_invalid_order')
.beginSubcases()
.combine('firstPassEnd', [true, false])
.combine('endPasses', [[], [0], [1], [0, 1], [1, 0]])
// Don't end the first pass multiple times (that generates a validation error but doesn't invalidate the encoder)
.unless(p => p.firstPassEnd && p.endPasses.includes(0))
)
.fn(t => {
const { pass0Type, pass1Type, firstPassEnd, endPasses } = t.params;
Expand All @@ -83,15 +77,16 @@ g.test('pass_end_invalid_order')

const passes = [firstPass, secondPass];
for (const index of endPasses) {
passes[index].end();
const validEnd = (index === 0 && !firstPassEnd) || (index === 1 && firstPassEnd);
t.expectValidationError(() => {
passes[index].end();
}, !validEnd);
}

// If {endPasses} is '[1]' and {firstPass} ends, it's a control case.
const valid = firstPassEnd && objectEquals(endPasses, [1]);

const validFinish = firstPassEnd && endPasses.includes(1);
t.expectValidationError(() => {
encoder.finish();
}, !valid);
}, !validFinish);
});

g.test('call_after_successful_finish')
Expand Down