You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Grackle currently does not allow the H/He ratio to change and instead resets everything according to the HydrogenFractionByMass parameter inside make_consistent_g (in solve_rate_cool_g.F). I propose to change this to recording the H/He ratio prior to integration and then resetting to this afterward.
Separately, @mabruzzo's comment in PR #215 has reminded me to check whether the documentation and usage of the HydrogenFractionByMass parameter are consistent, specifically that it is used as the mass fraction of H in the primordial gas and not the total gas density.
The text was updated successfully, but these errors were encountered:
Grackle currently does not allow the H/He ratio to change and instead resets everything according to the
HydrogenFractionByMass
parameter insidemake_consistent_g
(insolve_rate_cool_g.F
). I propose to change this to recording the H/He ratio prior to integration and then resetting to this afterward.Separately, @mabruzzo's comment in PR #215 has reminded me to check whether the documentation and usage of the
HydrogenFractionByMass
parameter are consistent, specifically that it is used as the mass fraction of H in the primordial gas and not the total gas density.The text was updated successfully, but these errors were encountered: