Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a variable HydrogenFractionByMass #234

Open
brittonsmith opened this issue Aug 19, 2024 · 0 comments
Open

Allow a variable HydrogenFractionByMass #234

brittonsmith opened this issue Aug 19, 2024 · 0 comments
Assignees
Labels
documentation Documentation needed enhancement New feature or request

Comments

@brittonsmith
Copy link
Contributor

Grackle currently does not allow the H/He ratio to change and instead resets everything according to the HydrogenFractionByMass parameter inside make_consistent_g (in solve_rate_cool_g.F). I propose to change this to recording the H/He ratio prior to integration and then resetting to this afterward.

Separately, @mabruzzo's comment in PR #215 has reminded me to check whether the documentation and usage of the HydrogenFractionByMass parameter are consistent, specifically that it is used as the mass fraction of H in the primordial gas and not the total gas density.

@brittonsmith brittonsmith added enhancement New feature or request documentation Documentation needed labels Aug 19, 2024
@brittonsmith brittonsmith self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation needed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant