Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support converting lokireceiver #242

Open
rfratto opened this issue Feb 21, 2024 · 4 comments · May be fixed by grafana/agent#6782
Open

Support converting lokireceiver #242

rfratto opened this issue Feb 21, 2024 · 4 comments · May be fixed by grafana/agent#6782
Labels
enhancement New feature or request

Comments

@rfratto
Copy link
Member

rfratto commented Feb 21, 2024

No description provided.

@hainenber
Copy link
Contributor

This component is not a wrapper of similarly named OpenTelemetry collector so I think we'll need to rewire the system to have it worked. Still, I think the conversion is possible but would be pretty awkward and prone to tech debts in the future.

Wdyt?

@rfratto
Copy link
Member Author

rfratto commented Mar 18, 2024

This component is not a wrapper of similarly named OpenTelemetry collector so I think we'll need to rewire the system to have it worked. Still, I think the conversion is possible but would be pretty awkward and prone to tech debts in the future.

Wdyt?

I think for now we can close this as a won't-do (yet). I agree best-effort conversion is possible (similarly to what grafana/agent#6505 does for the lokiexporter), and so we might be interested in doing this in the future, but most of the work we're been doing for grafana/agent#6419 have been for components where 1:1 conversions exist.

Given the above, I'll close this for now and we can revisit later.

@rfratto rfratto closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@tpaschalis
Copy link
Member

but most of the work we're been doing for grafana/agent#6419 have been for components where 1:1 conversions exist.

I'm not sure why we chose to close this one out? The upstream component sounds like it has a counterpart in loki.source.api. Am I missing something? cc @rfratto

@rfratto
Copy link
Member Author

rfratto commented Mar 19, 2024

I think I understood what the counterpart to this component was; I was thinking this was similar to prometheusreceiver where we didn't have a direct equivalent. Given that, it does make sense to open this one back up. Sorry for the confusion here.

@rfratto rfratto reopened this Mar 19, 2024
@rfratto rfratto added the enhancement New feature or request label Apr 9, 2024
@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants