Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow: Add total_components metric to Grafana Agent #6916

Open
Cimbel opened this issue May 20, 2024 · 2 comments
Open

Flow: Add total_components metric to Grafana Agent #6916

Cimbel opened this issue May 20, 2024 · 2 comments
Labels
proposal Proposal or RFC

Comments

@Cimbel
Copy link

Cimbel commented May 20, 2024

Hi team. I currently working on creating post deployment test for Grafana Agent and encountered an issue to check how many components are healthy out of existed ones. I have tried to make it just getting HTML page but from perspective of programming langage it's too complicated. I propose to add new metric called smth like "total_components" there is alredy metric in place called "agent_component_controller_running_components" that represents numbers of healthy components. I would like to have a metric that shows its total number no matter if they are healthy or not to understand how many components are healthy out of n numbers of total. Thanks

@Cimbel Cimbel added the proposal Proposal or RFC label May 20, 2024
@tpaschalis
Copy link
Member

How about using an aggregation (eg. a sum) on the existing agent_component_controller_running_components metric?

@Cimbel
Copy link
Author

Cimbel commented May 22, 2024

@tpaschalis I'm not sure If I got you right. Based on what should I make an aggregation ? agent_component_controller_running_components metric shows total number of running components by health. How should I get the number of healthy components by health status then ? It would be great to have additional metric that shows how many components in status healthy. Based on that it will be simple subtraction agent_component_controller_running_components - total_healthy_components and then you easily get the number of unhealthy components that running on the Agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposal or RFC
Projects
None yet
Development

No branches or pull requests

2 participants