Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows exporter module - Metrics #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Imshelledin21
Copy link
Contributor

There are still a few outstanding items that I haven't managed to get working

  • [textfile_directory] argument. When trying to specify a custom path (i.e. C:\Prometheus\Files): escaping slashes threw an error with Alloy, and the service wouldn't start on Windows. I'm probably just missing something stupid here.
  • [timeout] attribute on prometheus.windows.exporter threw an error when specified in config.

I'll dig further into those, but the module works as-is currently, and supports the Windows Integration Dashboards in Grafana Cloud (Metric Queries Only).

I have a few other ideas for expanding this module out some more, but I'll get to those later.

  • scrape existing windows exporter service and remote write metrics. From my sampling of customers at least, they have historically used the agent windows exporter integration, rather than using the vanilla windows exporter, hence the direction I took this one initially.
  • additional_collectors argument. Provide the ability to add collectors on top of the default one, without having to specify the whole default list again
  • expansion for additional collector config blocks

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2024

CLA assistant check
All committers have signed the CLA.

@Imshelledin21 Imshelledin21 linked an issue Apr 11, 2024 that may be closed by this pull request
@Imshelledin21 Imshelledin21 self-assigned this Apr 17, 2024
@timo1707
Copy link

Hi @Imshelledin21 :
when adding the text_file block to prometheus.exporter.windows "local" it should work.

I have a smartstatus.prom in this path, and its working fine. but i am not using the argument yet in my case.

text_file {
    text_file_directory = "C:\\ProgramData\\GrafanaLabs\\Alloy"
  }

@github-actions github-actions bot deleted the windows-exporter-module branch August 15, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module for windows-exporter
4 participants