Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules sync swaps Updated and Created totals in summary #267

Open
coderalex opened this issue Jan 10, 2023 · 0 comments · May be fixed by #268
Open

rules sync swaps Updated and Created totals in summary #267

coderalex opened this issue Jan 10, 2023 · 0 comments · May be fixed by #268

Comments

@coderalex
Copy link

Currently, rules sync is reporting the number of groups created as the number of groups updated and vice versa.

To fix, we need to have created, updated, deleted instead of updated, created, deleted here:

cortex-tools/pkg/commands/rules.go

Line 616 in cb81907

updated, created, deleted := rules.SummarizeChanges(changes)

@coderalex coderalex linked a pull request Jan 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorder return values for SummarizeChanges in sync coderalex/cortex-tools
1 participant
@coderalex