Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return fatal when no rules are loaded yet #31

Open
gotjosh opened this issue May 22, 2020 · 0 comments
Open

Do not return fatal when no rules are loaded yet #31

gotjosh opened this issue May 22, 2020 · 0 comments

Comments

@gotjosh
Copy link
Collaborator

gotjosh commented May 22, 2020

When you have no rules loaded yet, and try to do a cortextool rules list the output you'll get is the following:

$ cortextool rules list
FATA[0000] unable to read rules from cortex, requested resource not found

This is a bit deceiving given, we were able to load rules there just aren't any yet.
friedrichg referenced this issue in cortexproject/cortex-tools Aug 1, 2023
@khaines
Supporting externally managed Cortex Config (#31)
93baa61 
* enabling option to specify a cortex config created externally to this chart

Signed-off-by: Ken Haines <[email protected]>

* updating deployment hash of secret template, to only occur if cortex is using the template managed config.yaml

Signed-off-by: Ken Haines <[email protected]>

* updating ignore file

Signed-off-by: Ken Haines <[email protected]>

* adding externalConfigVersion property and using it in deployment annotations for change updates

Signed-off-by: Ken Haines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gotjosh