Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richer diff when running cortextool diff|sync #34

Open
gotjosh opened this issue May 22, 2020 · 4 comments
Open

Richer diff when running cortextool diff|sync #34

gotjosh opened this issue May 22, 2020 · 4 comments

Comments

@gotjosh
Copy link
Collaborator

gotjosh commented May 22, 2020

Right now, when you use the diff command it will only tell you which groups are going to be changed, but does not tell you which individual rules/alerts are changing.

I would be good to have an idea of what exactly is changing when you run this or the sync command.

@gotjosh gotjosh changed the title Improve diff Richer diff when running cortextool diff|sync May 22, 2020
@gotjosh
Copy link
Collaborator Author

gotjosh commented May 22, 2020

To expand on this, it seems that running sync/diff after syncing will also result in updates - I would have expected this to no-op.

@justinTM
Copy link
Contributor

justinTM commented Jul 16, 2021

@gotjosh take a look at this line:

if verbose {

trying to figure out how to increase verbosity with a flag

@justinTM
Copy link
Contributor

@gotjosh it is forced to false always:

return p.PrintComparisonResult(changes, false)

@justinTM
Copy link
Contributor

justinTM commented Jul 16, 2021

@gotjosh see #199

friedrichg referenced this issue in cortexproject/cortex-tools Aug 1, 2023
… Publishing not ready addresses is also required since the frontends wont go ready until a querier has connected, and the queriers wont find any frontend SRV records until they are ready (#34)

Signed-off-by: Roger Steneteg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants