Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Memberlist secret configuration #186

Open
aknuds1 opened this issue Jul 7, 2022 · 2 comments
Open

Expose Memberlist secret configuration #186

aknuds1 opened this issue Jul 7, 2022 · 2 comments
Assignees
@aknuds1
Labels
enhancement New feature or request

Comments

@aknuds1
Copy link
Collaborator

aknuds1 commented Jul 7, 2022 •
edited
Loading

Expose Memberlist secret configuration, so a cluster unique secret key can be used to prevent different clusters from joining each other. The secret key is typically derived by hashing a cluster name.
@aknuds1 aknuds1 self-assigned this Jul 7, 2022
@aknuds1 aknuds1 added the enhancement New feature or request label Jul 7, 2022
@pracucci
Copy link
Contributor

pracucci commented Jul 7, 2022

We also need to come up with a migration plan. I think that to migrate we need to expose GossipVerifyIncoming and GossipVerifyOutgoing. I'm not sure we need to expose both of them: I think only exposing a "verify secret enabled" is enough and then internally we set both GossipVerifyIncoming and GossipVerifyOutgoing to that value.

@aknuds1
Copy link
Collaborator Author

aknuds1 commented Jul 7, 2022

Thanks for the input @pracucci :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aknuds1 aknuds1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aknuds1 @pracucci