Merge remote-tracking branch 'origin/master' into v1.0.x

Author: kminehart

pkg/github/issues.go

@@ -41,7 +41,8 @@ func (c Issues) Frames() data.Frames {
 	for _, v := range c {
 		var closedAt *time.Time
 		if !v.ClosedAt.Time.IsZero() {
-			closedAt = &v.ClosedAt.Time
+			t := v.ClosedAt.Time
+			closedAt = &t
 		}
 
 		frame.AppendRow(

pkg/github/issues_test.go

@@ -41,8 +41,10 @@ func TestIssuesDataframe(t *testing.T) {
 
 	issues := Issues{
 		Issue{
-			Title:    "Issue #1",
-			ClosedAt: githubv4.DateTime{},
+			Title: "Issue #1",
+			ClosedAt: githubv4.DateTime{
+				Time: time.Time{},
+			},
 			CreatedAt: githubv4.DateTime{
 				Time: createdAt,
 			},
@@ -82,6 +84,28 @@ func TestIssuesDataframe(t *testing.T) {
 				},
 			},
 		},
+		Issue{
+			Title: "Issue #3",
+			ClosedAt: githubv4.DateTime{
+				Time: time.Time{},
+			},
+			CreatedAt: githubv4.DateTime{
+				Time: createdAt,
+			},
+			Closed: false,
+			Author: struct {
+				User "graphql:\"... on User\""
+			}{
+				User: User{
+					ID:      "3",
+					Login:   "firstUser",
+					Name:    "First User",
+					Company: "ACME Corp",
+					Email:   "[email protected]",
+					URL:     "",
+				},
+			},
+		},
 	}
 
 	if err := testutil.CheckGoldenFramer("issues", issues); err != nil {

pkg/github/testdata/issues.golden.txt

@@ -2,16 +2,17 @@
 
 Frame[0] 
 Name: issues
-Dimensions: 6 Fields by 2 Rows
+Dimensions: 6 Fields by 3 Rows
 +----------------+----------------+----------------------+--------------+---------------------------------+---------------------------------+
 | Name: title    | Name: author   | Name: author_company | Name: closed | Name: created_at                | Name: closed_at                 |
 | Labels:        | Labels:        | Labels:              | Labels:      | Labels:                         | Labels:                         |
 | Type: []string | Type: []string | Type: []string       | Type: []bool | Type: []time.Time               | Type: []*time.Time              |
 +----------------+----------------+----------------------+--------------+---------------------------------+---------------------------------+
 | Issue #1       | firstUser      | ACME Corp            | false        | 2020-08-25 16:21:56 +0000 +0000 | null                            |
 | Issue #2       | secondUser     | ACME Corp            | true         | 2020-08-25 16:21:56 +0000 +0000 | 2020-08-25 22:21:56 +0000 +0000 |
+| Issue #3       | firstUser      | ACME Corp            | false        | 2020-08-25 16:21:56 +0000 +0000 | null                            |
 +----------------+----------------+----------------------+--------------+---------------------------------+---------------------------------+
 
 
 ====== TEST DATA RESPONSE (arrow base64) ======
-FRAME=QVJST1cxAAD/////GAMAABAAAAAAAAoADgAMAAsABAAKAAAAFAAAAAAAAAEDAAoADAAAAAgABAAKAAAACAAAAFQAAAACAAAAKAAAAAQAAABw/f//CAAAAAwAAAAAAAAAAAAAAAUAAAByZWZJZAAAAJD9//8IAAAAEAAAAAYAAABpc3N1ZXMAAAQAAABuYW1lAAAAAAYAAAAoAgAAuAEAAEwBAADwAAAAgAAAABgAAAAAABIAGAAUABMAEgAMAAAACAAEABIAAAAUAAAAQAAAAEAAAAAAAAoBQAAAAAEAAAAEAAAABP7//wgAAAAUAAAACQAAAGNsb3NlZF9hdAAAAAQAAABuYW1lAAAAAAAAAACa////AAADAAkAAABjbG9zZWRfYXQAAAB6/v//FAAAAEAAAABIAAAAAAAACkgAAAABAAAABAAAAGj+//8IAAAAFAAAAAoAAABjcmVhdGVkX2F0AAAEAAAAbmFtZQAAAAAAAAAAAAAGAAgABgAGAAAAAAADAAoAAABjcmVhdGVkX2F0AADm/v//FAAAADwAAAA8AAAAAAAABjgAAAABAAAABAAAANT+//8IAAAAEAAAAAYAAABjbG9zZWQAAAQAAABuYW1lAAAAAAAAAADM/v//BgAAAGNsb3NlZAAAPv///xQAAABEAAAARAAAAAAAAAVAAAAAAQAAAAQAAAAs////CAAAABgAAAAOAAAAYXV0aG9yX2NvbXBhbnkAAAQAAABuYW1lAAAAAAAAAAAs////DgAAAGF1dGhvcl9jb21wYW55AACm////FAAAADwAAAA8AAAAAAAABTgAAAABAAAABAAAAJT///8IAAAAEAAAAAYAAABhdXRob3IAAAQAAABuYW1lAAAAAAAAAACM////BgAAAGF1dGhvcgAAAAASABgAFAAAABMADAAAAAgABAASAAAAFAAAAEQAAABIAAAAAAAABUQAAAABAAAADAAAAAgADAAIAAQACAAAAAgAAAAQAAAABQAAAHRpdGxlAAAABAAAAG5hbWUAAAAAAAAAAAQABAAEAAAABQAAAHRpdGxlAAAAAAAAAP////+oAQAAFAAAAAAAAAAMABYAFAATAAwABAAMAAAAoAAAAAAAAAAUAAAAAAAAAwMACgAYAAwACAAEAAoAAAAUAAAACAEAAAIAAAAAAAAAAAAAAA8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAABAAAAAAAAAAEAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAIAAAAAAAAAAQAAAAAAAAADAAAAAAAAAAGAAAAAAAAABIAAAAAAAAAAAAAAAAAAAASAAAAAAAAAAQAAAAAAAAAFgAAAAAAAAAGAAAAAAAAABwAAAAAAAAAAAAAAAAAAAAcAAAAAAAAAAIAAAAAAAAAHgAAAAAAAAAAAAAAAAAAAB4AAAAAAAAABAAAAAAAAAAiAAAAAAAAAAIAAAAAAAAAJAAAAAAAAAAEAAAAAAAAAAAAAAABgAAAAIAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAIAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAgAAAAAAAAABAAAAAAAAAAAAAAAIAAAAEAAAAAAAAABJc3N1ZSAjMUlzc3VlICMyAAAAAAkAAAATAAAAAAAAAGZpcnN0VXNlcnNlY29uZFVzZXIAAAAAAAAAAAAJAAAAEgAAAAAAAABBQ01FIENvcnBBQ01FIENvcnAAAAAAAAACAAAAAAAAAABo7bJVjy4WAGjtslWPLhYCAAAAAAAAAAAAAAAAAAAAAChB1/qiLhYQAAAADAAUABIADAAIAAQADAAAABAAAAAsAAAAOAAAAAAAAwABAAAAKAMAAAAAAACwAQAAAAAAAKAAAAAAAAAAAAAAAAAAAAAAAAoADAAAAAgABAAKAAAACAAAAFQAAAACAAAAKAAAAAQAAABw/f//CAAAAAwAAAAAAAAAAAAAAAUAAAByZWZJZAAAAJD9//8IAAAAEAAAAAYAAABpc3N1ZXMAAAQAAABuYW1lAAAAAAYAAAAoAgAAuAEAAEwBAADwAAAAgAAAABgAAAAAABIAGAAUABMAEgAMAAAACAAEABIAAAAUAAAAQAAAAEAAAAAAAAoBQAAAAAEAAAAEAAAABP7//wgAAAAUAAAACQAAAGNsb3NlZF9hdAAAAAQAAABuYW1lAAAAAAAAAACa////AAADAAkAAABjbG9zZWRfYXQAAAB6/v//FAAAAEAAAABIAAAAAAAACkgAAAABAAAABAAAAGj+//8IAAAAFAAAAAoAAABjcmVhdGVkX2F0AAAEAAAAbmFtZQAAAAAAAAAAAAAGAAgABgAGAAAAAAADAAoAAABjcmVhdGVkX2F0AADm/v//FAAAADwAAAA8AAAAAAAABjgAAAABAAAABAAAANT+//8IAAAAEAAAAAYAAABjbG9zZWQAAAQAAABuYW1lAAAAAAAAAADM/v//BgAAAGNsb3NlZAAAPv///xQAAABEAAAARAAAAAAAAAVAAAAAAQAAAAQAAAAs////CAAAABgAAAAOAAAAYXV0aG9yX2NvbXBhbnkAAAQAAABuYW1lAAAAAAAAAAAs////DgAAAGF1dGhvcl9jb21wYW55AACm////FAAAADwAAAA8AAAAAAAABTgAAAABAAAABAAAAJT///8IAAAAEAAAAAYAAABhdXRob3IAAAQAAABuYW1lAAAAAAAAAACM////BgAAAGF1dGhvcgAAAAASABgAFAAAABMADAAAAAgABAASAAAAFAAAAEQAAABIAAAAAAAABUQAAAABAAAADAAAAAgADAAIAAQACAAAAAgAAAAQAAAABQAAAHRpdGxlAAAABAAAAG5hbWUAAAAAAAAAAAQABAAEAAAABQAAAHRpdGxlAAAAQAMAAEFSUk9XMQ==
+FRAME=QVJST1cxAAD/////GAMAABAAAAAAAAoADgAMAAsABAAKAAAAFAAAAAAAAAEDAAoADAAAAAgABAAKAAAACAAAAFQAAAACAAAAKAAAAAQAAABw/f//CAAAAAwAAAAAAAAAAAAAAAUAAAByZWZJZAAAAJD9//8IAAAAEAAAAAYAAABpc3N1ZXMAAAQAAABuYW1lAAAAAAYAAAAoAgAAuAEAAEwBAADwAAAAgAAAABgAAAAAABIAGAAUABMAEgAMAAAACAAEABIAAAAUAAAAQAAAAEAAAAAAAAoBQAAAAAEAAAAEAAAABP7//wgAAAAUAAAACQAAAGNsb3NlZF9hdAAAAAQAAABuYW1lAAAAAAAAAACa////AAADAAkAAABjbG9zZWRfYXQAAAB6/v//FAAAAEAAAABIAAAAAAAACkgAAAABAAAABAAAAGj+//8IAAAAFAAAAAoAAABjcmVhdGVkX2F0AAAEAAAAbmFtZQAAAAAAAAAAAAAGAAgABgAGAAAAAAADAAoAAABjcmVhdGVkX2F0AADm/v//FAAAADwAAAA8AAAAAAAABjgAAAABAAAABAAAANT+//8IAAAAEAAAAAYAAABjbG9zZWQAAAQAAABuYW1lAAAAAAAAAADM/v//BgAAAGNsb3NlZAAAPv///xQAAABEAAAARAAAAAAAAAVAAAAAAQAAAAQAAAAs////CAAAABgAAAAOAAAAYXV0aG9yX2NvbXBhbnkAAAQAAABuYW1lAAAAAAAAAAAs////DgAAAGF1dGhvcl9jb21wYW55AACm////FAAAADwAAAA8AAAAAAAABTgAAAABAAAABAAAAJT///8IAAAAEAAAAAYAAABhdXRob3IAAAQAAABuYW1lAAAAAAAAAACM////BgAAAGF1dGhvcgAAAAASABgAFAAAABMADAAAAAgABAASAAAAFAAAAEQAAABIAAAAAAAABUQAAAABAAAADAAAAAgADAAIAAQACAAAAAgAAAAQAAAABQAAAHRpdGxlAAAABAAAAG5hbWUAAAAAAAAAAAQABAAEAAAABQAAAHRpdGxlAAAAAAAAAP////+oAQAAFAAAAAAAAAAMABYAFAATAAwABAAMAAAAyAAAAAAAAAAUAAAAAAAAAwMACgAYAAwACAAEAAoAAAAUAAAACAEAAAMAAAAAAAAAAAAAAA8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAABAAAAAAAAAAGAAAAAAAAAAoAAAAAAAAAAAAAAAAAAAAKAAAAAAAAAAQAAAAAAAAADgAAAAAAAAAIAAAAAAAAABYAAAAAAAAAAAAAAAAAAAAWAAAAAAAAAAQAAAAAAAAAGgAAAAAAAAAIAAAAAAAAACIAAAAAAAAAAAAAAAAAAAAiAAAAAAAAAAIAAAAAAAAAJAAAAAAAAAAAAAAAAAAAACQAAAAAAAAABgAAAAAAAAAqAAAAAAAAAAIAAAAAAAAALAAAAAAAAAAGAAAAAAAAAAAAAAABgAAAAMAAAAAAAAAAAAAAAAAAAADAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAAAAAAAAAAAAAMAAAAAAAAAAAAAAAAAAAADAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAACAAAAAAAAAAAAAAAIAAAAEAAAABgAAABJc3N1ZSAjMUlzc3VlICMySXNzdWUgIzMAAAAACQAAABMAAAAcAAAAZmlyc3RVc2Vyc2Vjb25kVXNlcmZpcnN0VXNlcgAAAAAAAAAACQAAABIAAAAbAAAAQUNNRSBDb3JwQUNNRSBDb3JwQUNNRSBDb3JwAAAAAAACAAAAAAAAAABo7bJVjy4WAGjtslWPLhYAaO2yVY8uFgIAAAAAAAAAAAAAAAAAAAAAKEHX+qIuFgAAAAAAAAAAEAAAAAwAFAASAAwACAAEAAwAAAAQAAAALAAAADgAAAAAAAMAAQAAACgDAAAAAAAAsAEAAAAAAADIAAAAAAAAAAAAAAAAAAAAAAAKAAwAAAAIAAQACgAAAAgAAABUAAAAAgAAACgAAAAEAAAAcP3//wgAAAAMAAAAAAAAAAAAAAAFAAAAcmVmSWQAAACQ/f//CAAAABAAAAAGAAAAaXNzdWVzAAAEAAAAbmFtZQAAAAAGAAAAKAIAALgBAABMAQAA8AAAAIAAAAAYAAAAAAASABgAFAATABIADAAAAAgABAASAAAAFAAAAEAAAABAAAAAAAAKAUAAAAABAAAABAAAAAT+//8IAAAAFAAAAAkAAABjbG9zZWRfYXQAAAAEAAAAbmFtZQAAAAAAAAAAmv///wAAAwAJAAAAY2xvc2VkX2F0AAAAev7//xQAAABAAAAASAAAAAAAAApIAAAAAQAAAAQAAABo/v//CAAAABQAAAAKAAAAY3JlYXRlZF9hdAAABAAAAG5hbWUAAAAAAAAAAAAABgAIAAYABgAAAAAAAwAKAAAAY3JlYXRlZF9hdAAA5v7//xQAAAA8AAAAPAAAAAAAAAY4AAAAAQAAAAQAAADU/v//CAAAABAAAAAGAAAAY2xvc2VkAAAEAAAAbmFtZQAAAAAAAAAAzP7//wYAAABjbG9zZWQAAD7///8UAAAARAAAAEQAAAAAAAAFQAAAAAEAAAAEAAAALP///wgAAAAYAAAADgAAAGF1dGhvcl9jb21wYW55AAAEAAAAbmFtZQAAAAAAAAAALP///w4AAABhdXRob3JfY29tcGFueQAApv///xQAAAA8AAAAPAAAAAAAAAU4AAAAAQAAAAQAAACU////CAAAABAAAAAGAAAAYXV0aG9yAAAEAAAAbmFtZQAAAAAAAAAAjP///wYAAABhdXRob3IAAAAAEgAYABQAAAATAAwAAAAIAAQAEgAAABQAAABEAAAASAAAAAAAAAVEAAAAAQAAAAwAAAAIAAwACAAEAAgAAAAIAAAAEAAAAAUAAAB0aXRsZQAAAAQAAABuYW1lAAAAAAAAAAAEAAQABAAAAAUAAAB0aXRsZQAAAEADAABBUlJPVzE=