Create ingress instead of route in OpenShift

[alexlionnel]

Describe the bug
Ingress resource is not created when i create a grafana instance using grafana operator

Version
I am using grafana-operator v5.8.0 and openshift 4.12.53

To Reproduce
Steps to reproduce the behavior:

1. Install grafana-operator from openshift interface
2. create a grafana ressource using this yml config

apiVersion: grafana.integreatly.org/v1beta1
kind: Grafana
metadata:
  name: grafana
  labels:
    dashboards: "grafana"
  namespace: grafana-project
spec:
  config:
    log:
      mode: "console"
    auth:
      disable_login_form: "false"
    security:
      admin_user: root
      admin_password: secret
  ingress:
    spec:
      ingressClassName: openshift-default
      rules:
        - host: <my_domain.com>
          http:
            paths:
              - backend:
                  service:
                    name: grafana-service
                    port:
                      number: 3000
                path: /
                pathType: Prefix

Expected behavior
Ingress resource should be created but it isn't
Same result with ingressClassName: nginx

[NissesSenap]

@alexlionnel do you want to use ingress, or do you actually want to use OCP routes?
There is a root object that you can use instead grafana.spec.route

If I remember correctly, we have more or less removed the possibility to create an ingress from OCP users without thinking of it.

[alexlionnel]

In fact, i want to use an ingress with tls config, using cert manager

 ingress:
    metadata:
      cert-manager.io/cluster-issuer: letsencrypt-issuer
    spec:
      ingressClassName: openshift-default
      tls:
        - hosts:
          - <my_domain.com>
        secretName: secret-cert-tls
      rules:
        - host: <my_domain.com>
          http:
            paths:
              - backend:
                  service:
                    name: grafana-service
                    port:
                      number: 3000
                path: /
                pathType: Prefix

But ingress is not created

[NissesSenap]

With our current implementation, that is not possible.
We did an assumption that anyone using OCP would only want to use routes.

grafana-operator/controllers/reconcilers/grafana/ingress_reconciler.go

Lines 35 to 45 in e43aff9

	func (r *IngressReconciler) Reconcile(ctx context.Context, cr *v1beta1.Grafana, status *v1beta1.GrafanaStatus, vars *v1beta1.OperatorReconcileVars, scheme *runtime.Scheme) (v1beta1.OperatorStageStatus, error) {
	logger := log.FromContext(ctx).WithName("IngressReconciler")
	if r.isOpenShift {
	logger.Info("reconciling route", "platform", "openshift")
	return r.reconcileRoute(ctx, cr, status, vars, scheme)
	} else {
	logger.Info("reconciling ingress", "platform", "kubernetes")
	return r.reconcileIngress(ctx, cr, status, vars, scheme)
	}
	}

As a workaround, I recommend that you setup an ingress separately from the operator.
I will mark this as a bug, if you or someone else have time to create a fix for this, that would be great.
The maintainers have lots to do, and I don't think this will be a priority one thing for us to solve.

Sorry for the inconvenience.

[Hipska]

I came across this and was wondering why use Ingress instead of Route? I'm new to OCP, but using routes seems fine and is also encrypted? What is the benefit of using Ingress?

[NissesSenap]

@Hipska due to this #1484 (comment)