Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject cluster CA into operator pod on openshift #1683

Open
marpears opened this issue Sep 18, 2024 · 2 comments
Open

Inject cluster CA into operator pod on openshift #1683

marpears opened this issue Sep 18, 2024 · 2 comments
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marpears
Copy link

Describe the bug
5.13.0 introduces a change which by default enforces TLS when communicating with external Grafanas.

When following the docs it states to create a kubernetes.io/tls secret with the ca.crt. In my case I only need to specify a ca bundle and there is no client TLS verification required. Creating a kubernetes.io/tls secret with blank tls.crt and tls.key causes an error in the admission webhook and also leads to errors in the grafana operator which complains about the empty tls.crt and tls.key.

A secret of type opaque was created instead which contains the ca bundle under key ca.crt, which worked. But since this is just a CA bundle, why can't this be stored in a ConfigMap? This way, the mechanism described in the OCP docs could be used to create a ConfigMap containing the CA bundle and be referenced under something like spec.external.tls.caBundle.name in the Grafana CR

Version
5.13.0

@marpears marpears added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2024
@marpears
Copy link
Author

Could the Grafana operator on Openshift create the config map using the the mechanism described in the OCP docs and mount it into the grafana-operator-controller-manager-v5 pod?

That way, the change to enforce TLS would be less likely to be a breaking change if the cluster has been set up with a user-ca-bundle and no modifications to any Grafana CRs would be required.

@theSuess
Copy link
Member

Could the Grafana operator on Openshift create the config map using the the mechanism described in the OCP docs and mount it into the grafana-operator-controller-manager-v5 pod?

This is a great idea! I'll rephrase this issue and will try to implement it for the next release

@theSuess theSuess changed the title Not able to communicate with external Grafana since 5.13.0 on openshift Inject cluster CA into operator pod on openshift Sep 19, 2024
@theSuess theSuess added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants