Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: provision notificationTemplates trough the operator #1736

Open
Marb0l opened this issue Oct 29, 2024 · 2 comments
Open

Feature: provision notificationTemplates trough the operator #1736

Marb0l opened this issue Oct 29, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Marb0l
Copy link

Marb0l commented Oct 29, 2024

Is your feature request related to a problem? Please describe.
We want to provision all the configurations trough the operator but notificationTemplates are missing, i think it would be useful to add them as they can be shared trough grafana instances and in case of a redeploy they have to be added again manually

@Marb0l Marb0l added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 29, 2024
@Baarsgaard
Copy link
Contributor

Baarsgaard commented Oct 30, 2024

If you want to provision templates today, you can configure it per GrafanaContactPoint if it has a field that supports templating:

 settings:
    message: |
      {{ .CommonLabels.alertname }} {{ .CommonLabels.namespace }}

If you provision this through Helm, you can wrap the template to avoid Helm templating errors

 settings:
    message: |
      {{` {{ .CommonLabels.alertname }} {{ .CommonLabels.namespace }} `}}

@theSuess theSuess added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2024
@theSuess
Copy link
Member

theSuess commented Nov 4, 2024

Thanks for the issue! It is certainly a valid feature request and should be straight forward to implement. As this is the first time this has been requested, we're not prioritizing it super high, but it should be implemented eventually. That being said, this looks like a good first issue to start out on as the resource is very small and doesn't have any dependencies

@theSuess theSuess added the good first issue Good for newcomers label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants