Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore numerical folderId for diffs #592

Open
jhuizingh opened this issue Feb 21, 2025 · 0 comments
Open

Ignore numerical folderId for diffs #592

jhuizingh opened this issue Feb 21, 2025 · 0 comments

Comments

@jhuizingh
Copy link

Feature Request

The numerical folderId is included in the grizzly resources created with grr pull. This seems unnecessary given the existence of the folderUid. Including folderId in the diff causes there to always be a diff when using the same grizzly resource to manage multiple Grafana instances. Example of a LibraryElement:

Grafana A

$ grr diff panel-a1c2a383-9319-4216-9967-101de787a7b7.yaml
INFO Diff-ing 1 resources
LibraryElement.a1c2a383-9319-4216-9967-101de787a7b7 no differences

Grafana B

$ grr diff panel-a1c2a383-9319-4216-9967-101de787a7b7.yaml
INFO Diff-ing 1 resources
LibraryElement.a1c2a383-9319-4216-9967-101de787a7b7 changes detected:
--- Remote
+++ Local
@@ -3,7 +3,7 @@
 metadata:
     name: a1c2a383-9319-4216-9967-101de787a7b7
 spec:
-    folderId: 35985
+    folderId: 87
     folderUid: b11afa54-725f-4450-a14f-f2a39bdcc868
     kind: 1
     model:

If I remove folderId from the yaml file, It shows up as a remove in the diff on both Grafanas.

My gut says the diff shouldn't consider the numerical folderId since the folderUid exists and can be set the same on multiple Grafana instances. I'd be happy for any other solution that reduces this unnecessary noise too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant