From 3291b98cad0cea54292025d91889575f116f0fe7 Mon Sep 17 00:00:00 2001 From: Lukasz Gut Date: Fri, 30 Jun 2023 15:12:25 +0200 Subject: [PATCH] output/cloudv2: Return empty string instead of "unknown" in rmCollector --- output/cloud/expv2/collect.go | 2 +- output/cloud/expv2/collect_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/output/cloud/expv2/collect.go b/output/cloud/expv2/collect.go index 5e85e5b90f7..bef49c2fec6 100644 --- a/output/cloud/expv2/collect.go +++ b/output/cloud/expv2/collect.go @@ -251,7 +251,7 @@ func (c *rmCollector) getStringTagFromTrail(trail *httpext.Trail, key string) st return tag } - return "unknown" + return "" } func (c *rmCollector) getIntTagFromTrail(trail *httpext.Trail, key string) int64 { diff --git a/output/cloud/expv2/collect_test.go b/output/cloud/expv2/collect_test.go index 7f923ca93d2..5b5bf28ea4e 100644 --- a/output/cloud/expv2/collect_test.go +++ b/output/cloud/expv2/collect_test.go @@ -408,8 +408,8 @@ func Test_requestMetadatasCollector_CollectRequestMetadatas_FiltersAndStoresHTTP TraceID: "test-trace-id-3", Start: time.Unix(19, 0), End: time.Unix(20, 0), - TestRunLabels: insights.TestRunLabels{ID: 1337, Scenario: "unknown", Group: "unknown"}, - ProtocolLabels: insights.ProtocolHTTPLabels{URL: "unknown", Method: "unknown", StatusCode: 0}, + TestRunLabels: insights.TestRunLabels{ID: 1337, Scenario: "", Group: ""}, + ProtocolLabels: insights.ProtocolHTTPLabels{URL: "", Method: "", StatusCode: 0}, }) }