Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart 1.9.25 fails to render #5065

Closed
fculpo opened this issue Sep 24, 2024 · 3 comments · Fixed by #5069
Closed

Helm Chart 1.9.25 fails to render #5065

fculpo opened this issue Sep 24, 2024 · 3 comments · Fixed by #5069
Labels
bug Something isn't working part:helm/kubernetes/docker

Comments

@fculpo
Copy link

fculpo commented Sep 24, 2024

What went wrong?

What happened:

  • Upgrade post 1.9.23 with default value (or custom) fails with
  • This seems to be a "conflict" between sub charts
❯ helm template grafana/oncall
Error: template: oncall/charts/redis/templates/replicas/serviceaccount.yaml:13:14: executing "oncall/charts/redis/templates/replicas/serviceaccount.yaml" at <include "common.labels.standard" (dict "customLabels" .Values.commonLabels "context" $)>: error calling include: template: oncall/charts/mariadb/charts/common/templates/_labels.tpl:6:27: executing "common.labels.standard" at <include "common.names.name" .>: error calling include: template: oncall/charts/mariadb/charts/common/templates/_names.tpl:6:18: executing "common.names.name" at <.Chart.Name>: nil pointer evaluating interface {}.Name

What did you expect to happen:

  • upgrade should succeed
  • chart should render with default values

How do we reproduce it?

  1. helm template grafana/oncall (1.9.25)

Grafana OnCall Version

v1.9.25

Product Area

Helm/Kubernetes/Docker

Grafana OnCall Platform?

Kubernetes

User's Browser?

No response

Anything else to add?

No response
@fculpo fculpo added the bug Something isn't working label Sep 24, 2024
@Brainpitcher
Copy link

Brainpitcher commented Sep 24, 2024 •
edited
Loading

Yeap i confirm, having almost the same on 24 to 25 - fails with:

Error: template: oncall/charts/oncall/charts/redis/templates/master/serviceaccount.yaml:13:14: executing "oncall/charts/oncall/charts/redis/templates/master/serviceaccount.yaml" at <include "common.labels.standard" (dict "customLabels" .Values.commonLabels "context" $)>: error calling include: template: oncall/charts/oncall/charts/rabbitmq/charts/common/templates/_labels.tpl:6:27: executing "common.labels.standard" at <include "common.names.name" .>: error calling include: template: oncall/charts/oncall/charts/rabbitmq/charts/common/templates/_names.tpl:6:18: executing "common.names.name" at <.Chart.Name>: nil pointer evaluating interface {}.Name
Use --debug flag to render out invalid YAML

looks like new dependencies versions have arrived

This was referenced Sep 24, 2024
Merged
Merged
@joeyorlando
Copy link
Contributor

this should get fixed in v1.9.29 of the chart (via #5069; on an unrelated note we had a GitHub Actions workflow hiccuping publishing > v1.9.25 of the helm chart, that has also been fixed)

github-merge-queue bot pushed a commit that referenced this issue Sep 24, 2024
@joeyorlando
fix "on helm release pr merged" GitHub Actions workflow (#5069)
7586b04 
# What this PR does

- Closes #5065
- Fixes [failing update Helm repo github
workflows](https://github.com/grafana/oncall/actions/workflows/on-helm-release-pr-merged.yml)
(due to `secrets. GH_HELM_RELEASE` now seeming to return "Bad
credentials")

## TODO

- [ ] after this PR is merged and change merged to `main`, remove
`GH_HELM_RELEASE` repository secret

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
@joeyorlando
Copy link
Contributor

FYI, v1.9.29 chart has now been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working part:helm/kubernetes/docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix "on helm release pr merged" GitHub Actions workflow grafana/oncall
3 participants
@fculpo @joeyorlando @Brainpitcher