Add symbolizer enabled tenant flag cli support and clean minor things

Author: marcsanmi

cmd/pyroscope/help-all.txt.tmpl

@@ -1079,6 +1079,8 @@ Usage of ./pyroscope:
     	True to enable zone-awareness and replicate blocks across different availability zones. This option needs be set both on the store-gateway and querier when running in microservices mode.
   -store-gateway.tenant-shard-size int
     	The tenant's shard size, used when store-gateway sharding is enabled. Value of 0 disables shuffle sharding for the tenant, that is all tenant blocks are sharded across all store-gateway replicas.
+  -symbolizer.tenant-enabled
+    	[experimental] When symbolizer.enabled is true, this controls whether symbolization is enabled for tenants by default. Can be overridden per-tenant. (default true)
   -target comma-separated-list-of-strings
     	Comma-separated list of Pyroscope modules to load. The alias 'all' can be used in the list to load a number of core modules and will enable single-binary mode.  (default all)
   -tenant-settings.collection-rules.alloy-template-path string

pkg/experiment/symbolizer/symbolizer.go

@@ -76,7 +76,7 @@ func (s *Symbolizer) SymbolizePprof(ctx context.Context, profile *googlev1.Profi
 		if mapping.HasFunctions && mapping.HasFilenames && mapping.HasLineNumbers {
 			continue
 		}
-		mappingsToSymbolize[uint64(i+1)] = true // MappingId is 1-indexed
+		mappingsToSymbolize[uint64(i+1)] = true
 	}
 	if len(mappingsToSymbolize) == 0 {
 		return nil
@@ -110,7 +110,7 @@ func (s *Symbolizer) groupLocationsByMapping(profile *googlev1.Profile, mappings
 			return nil, fmt.Errorf("invalid profile: location at index %d references non-existent mapping %d", i, loc.MappingId)
 		}
 
-		if !mappingsToSymbolize[loc.MappingId] || len(loc.Line) > 0 {
+		if !mappingsToSymbolize[loc.MappingId] {
 			continue
 		}
 
@@ -127,10 +127,6 @@ func (s *Symbolizer) groupLocationsByMapping(profile *googlev1.Profile, mappings
 func (s *Symbolizer) symbolizeLocationsForMapping(ctx context.Context, profile *googlev1.Profile, mappingID uint64, locs []locToSymbolize) error {
 	mapping := profile.Mapping[mappingID-1]
 
-	if mapping.HasFunctions && mapping.HasFilenames && mapping.HasLineNumbers {
-		return nil
-	}
-
 	binaryName, err := s.extractBinaryName(profile, mapping)
 	if err != nil {
 		return err
@@ -219,10 +215,6 @@ func (s *Symbolizer) updateProfileWithSymbols(profile *googlev1.Profile, mapping
 	}
 
 	for i, symLoc := range symLocs {
-		if len(symLoc.Lines) == 0 {
-			continue
-		}
-
 		locIdx := locs[i].idx
 		profile.Location[locIdx].Line = make([]*googlev1.Line, len(symLoc.Lines))
 

pkg/test/integration/helper.go

@@ -180,6 +180,8 @@ func (p *PyroscopeTest) Configure(t *testing.T, v2 bool) *PyroscopeTest {
 		p.config.Metastore.Raft.Dir = t.TempDir()
 		p.config.Metastore.Raft.SnapshotsDir = t.TempDir()
 		p.config.Metastore.FSM.DataDir = t.TempDir()
+		p.config.LimitsConfig.SymbolizerEnabled = false
+		p.config.Symbolizer.Enabled = false
 	}
 	return p
 }

pkg/validation/limits.go

@@ -193,6 +193,8 @@ func (l *Limits) RegisterFlags(f *flag.FlagSet) {
 	f.Var(&l.IngestionRelabelingDefaultRulesPosition, "distributor.ingestion-relabeling-default-rules-position", "Position of the default ingestion relabeling rules in relation to relabel rules from overrides. Valid values are 'first', 'last' or 'disabled'.")
 	_ = l.IngestionRelabelingRules.Set("[]")
 	f.Var(&l.IngestionRelabelingRules, "distributor.ingestion-relabeling-rules", "List of ingestion relabel configurations. The relabeling rules work the same way, as those of [Prometheus](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config). All rules are applied in the order they are specified. Note: In most situations, it is more effective to use relabeling directly in Grafana Alloy.")
+
+	f.BoolVar(&l.SymbolizerEnabled, "symbolizer.tenant-enabled", true, "When symbolizer.enabled is true, this controls whether symbolization is enabled for tenants by default. Can be overridden per-tenant.")
 }
 
 // UnmarshalYAML implements the yaml.Unmarshaler interface.