Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test_Concurrency in the query backend client package #3923

Open
kolesnikovae opened this issue Feb 17, 2025 · 0 comments
Open

Flaky Test_Concurrency in the query backend client package #3923

kolesnikovae opened this issue Feb 17, 2025 · 0 comments
Labels
tests

Comments

@kolesnikovae
Copy link
Collaborator

As we use the real transport in tests, if fails from time to time:

=== FAIL: pkg/experiment/query_backend/client Test_Concurrency (0.01s)
    client_test.go:108: 
        	Error Trace:	/home/runner/work/pyroscope/pyroscope/pkg/experiment/query_backend/client/client_test.go:108
        	Error:      	Received unexpected error:
        	            	listen tcp 127.0.0.1:36467: bind: address already in use
        	Test:       	Test_Concurrency

https://github.com/grafana/pyroscope/actions/runs/13364982979/job/37321769113?pr=3885

The failure reasons vary (timouts, EOF, etc.) but the solution is the same – use in-memory transport for tests that involve networking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kolesnikovae