Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "name" label requirement on StatefulSet's pods #15

Open
pracucci opened this issue May 11, 2022 · 2 comments · May be fixed by #18
Open

Remove the "name" label requirement on StatefulSet's pods #15

pracucci opened this issue May 11, 2022 · 2 comments · May be fixed by #18
Assignees
Labels
enhancement New feature or request

Comments

@pracucci
Copy link
Collaborator

The rollout-operator currently requires that each pod controlled by a StatefulSet managed by rollout-operator has the name label and its value is the name of the StatefulSet controlling it:

mustNewLabelsRequirement("name", selection.Equals, []string{sts.Spec.Template.Labels["name"]}),

I think we can get rid of this requirement, looking for the StatefulSet controlling the pod in a different way. For example, when running kubectl describe pod ... it shows a "Controlled By" field with the name of the StatefulSet controlling it.

@FUSAKLA
Copy link
Contributor

FUSAKLA commented Aug 4, 2022

Just bumped into this, It would be great to at least document it in the README until this gets resolved. This way, I had to dig into the code to make it work.

#17

@bboreham
Copy link

bboreham commented Aug 8, 2022

I believe that's done via the ownerReferences field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants