Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make bin #9

Open
jeff-cook opened this issue Jan 19, 2024 · 3 comments
Open

Can't make bin #9

jeff-cook opened this issue Jan 19, 2024 · 3 comments

Comments

@jeff-cook
Copy link

Is there a way to just download a pre-build bin?

When running

make

I get the following error

>> checking code style
>> checking license header
>> running golangci-lint
go list -e -compiled -test=true -export=false -deps=true -find=false -tags= -- ./... > /dev/null
/root/go/bin/golangci-lint run  ./...
make: *** [common-lint] Killed

When I comment the golangci-lint run command then I get this error.

{"err":"failed to open database","level":"error","msg":"Failed to connect to Snowflake."}

It looks like the build requires a test that connects to a real database before it will build the bin?

@schmikei
Copy link

@jeff-cook Could you try doing a

make common-build

?

As I think this should isolate to only build the exporter binary using promu in the current working directory called snowflake_exporter

common-build: promu
@echo ">> building binaries"
$(PROMU) build --prefix $(PREFIX) $(PROMU_BINARIES)

golangci-lint only supports linux, darwin and windows platforms on i386/amd64. So perhaps there's some kind of mismatch between Go version, arch/os thing going on. If you could share those details, that would be great!

Either way, I'll have someone take a look at the test soonish as I was able to replicate that quickly.

@StefanKurek
Copy link
Contributor

I actually believe that output is a bit of a red herring and is part of the normal test message output for one of the tests.

The I think they key is that the tests are out of date right now. There is already an open PR here to fix this, but it needs to be merged.

@StefanKurek
Copy link
Contributor

@gaantunes should be able to close this issue now as a PR was merged to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants